Join empty lines with only one space in join_selections
#8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the issue that lines with only spaces are getting joined as well
the-mikedavis
added
C-bug
|
This would be a good opportunity to add a test case for |
the-mikedavis
changed the title
join_selections
|
Damn, hm... may I ask if there's a possible way to start the tests for the other platforms so I can also try them locally? |
|
ok, just found act and I'll try with it. |
|
@the-mikedavis ok, could you please restart the workflow please? Hopefully it will work this time. |
the-mikedavis
approved these changes
Dec 6, 2023
pascalkuthe
approved these changes
Dec 6, 2023
helix-term/src/commands.rs
Outdated
| let separator = { | ||
| let line_end_index = line_end_char_index(&slice, line + 1); | ||
| let line_contains_only_space = end == line_end_index; | ||
| if line_contains_only_space { |
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Dec 11, 2023
…or#8989) * fix: helix-editor#8977 fixes the issue that lines with only spaces are getting joined as well * reverting some renamings * improve empty line check * adding integration test * reverting code block * fix conditon check for line end * applying suggested style
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
…or#8989) * fix: helix-editor#8977 fixes the issue that lines with only spaces are getting joined as well * reverting some renamings * improve empty line check * adding integration test * reverting code block * fix conditon check for line end * applying suggested style
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…or#8989) * fix: helix-editor#8977 fixes the issue that lines with only spaces are getting joined as well * reverting some renamings * improve empty line check * adding integration test * reverting code block * fix conditon check for line end * applying suggested style
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
…or#8989) * fix: helix-editor#8977 fixes the issue that lines with only spaces are getting joined as well * reverting some renamings * improve empty line check * adding integration test * reverting code block * fix conditon check for line end * applying suggested style
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…or#8989) * fix: helix-editor#8977 fixes the issue that lines with only spaces are getting joined as well * reverting some renamings * improve empty line check * adding integration test * reverting code block * fix conditon check for line end * applying suggested style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue that lines with only spaces are getting joined as well
fixes #8977